Allow usage of signal names #208
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds a mapping of signal numbers to signal names based on the "most common" (subjective) signals. - This allows the same config/script to be used on different platforms, for example: -r TERM:QUIT (15:3 on Linux vs. 25:20 on OS X). - Each entry is wrapped in a #ifdef SIG<NAME>/#endif pair in an attempt to make this implementation as portable as possible. - Names can be specified with or without the SIG prefix, and numbers and names can be used in any combination: -r 15:3, -r TERM:QUIT, -r SIGTERM:3, -r TERM:SIGQUIT, etc. - Corresponding signum_to_signame() and signame_to_signum() functions were added. - A new -l/--list option shows the mapping in use on the current system/platform/OS. - Debug output has been updated to include the signal name along with the number. Fixes Yelp#87.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-r TERM:QUIT(15:3on Linux vs.25:20on OS X).#ifdef SIG<NAME>/#endifpair in an attempt to make this implementation as portable as possible.SIGprefix, and numbers and names can be used in any combination:-r 15:3,-r TERM:QUIT,-r SIGTERM:3,-r TERM:SIGQUIT, etc.signum_to_signame()andsigname_to_signum()functions were added.-l/--listoption shows the mapping in use on the current system/platform/OS.Fixes #87.
The build of the signal map is a bit lanky in dumb-init.c due to all of the
#ifdef/#endif. It may be worth moving it into a separate file and usingexterns and#includes, but I kept everything together for this first stab at it.